With the iPhone, there are several ways to share or save photos. The quickest way is to use the USB cable and hook up to a PC or a Laptop, then sync.
I prefer to share photos on Facebook. It's very easy to do and keeps them in albums on your iPhone and Facebook. It is an instant way to share your pictures with everyone you care about. It can be done via the 3G or 4G cellular link, or via WiFi.
Loading pictures to share on this site is a little more convoluted the way I've been doing it. I email the pictures to myself, then save them onto the PC hard drive. Then I upload them to Photobucket. From Photobucket I copy the "IMG" link (bottom one) and copy it into the text box on this site. Works like a charm, but a little time consuming.
I haven't tried uploading to photobucket from my iPhone, but this is the next method I'll be trying, to cut out a couple of steps. There is a Photobucket APP for iPhone. That will be the way I upload in the future, provided it works as expected.
There are other photo sites out there, but I've used Photobucket for seven years and find it a great archive for pictures.